-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: proxying 104s Upload Resumption Supported
#34738
http: proxying 104s Upload Resumption Supported
#34738
Conversation
Hi @Nealsoni00, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
422ba43
to
27935a4
Compare
Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
…ponses Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
5a706e9
to
9471370
Compare
Looks like this fails to build
Please update the release notes. /wait |
Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
303783b
to
c9bd729
Compare
@RyanTheOptimist Build fix incoming. Where should I add release notes (other than in the PR description)?
|
a8e0ed2
to
d4afe75
Compare
ef13198
to
ad1eddd
Compare
/wait |
Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
2d100da
to
b86a01a
Compare
@RyanTheOptimist Is the change I made sufficient to test the propagation of the |
/wait |
Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
@RyanTheOptimist not sure why tests are failing — verified those same tests are failing on master. ![]() |
/wait |
7733ce7
to
ada8151
Compare
Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
88c7fc9
to
12344f2
Compare
@RyanTheOptimist It should be good now! |
Signed-off-by: Neal Soni <Nealsoni00@gmail.com>
@RyanTheOptimist sorry to re-ping. Would love to get this into master before it becomes out of date! Once in, what's the process to deprecate the runtime flag? Should I create a PR to remove it and leave it to y'alls discretion to merge when appropriate? |
I've sent you an invite to the "assignable" group - in ~6m when we cut the release where this is no longer needed the tool will file an issue your way that removal is appropriate. |
@alyssawilk happy to help clean up the runtime flag here — is there a ticket i should associate it to? |
Proxying 104s from upstream.
104 Upload Resumption Supported
is introduced indraft-ietf-httpbis-resumable-upload
spec.Continuation of the discussion in #19044
Modeled after: #19023
Risk Level: Low (minor refactor)
Testing: new integration test
Docs Changes: N/A
Release Notes:
Runtime guard: