rds: workaround for the use-after-free crash. #3957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't fix the underlying issue (that factory_context_ is being referenced after being freed), but it stops Envoy from crashing. *Risk Level*: Low *Testing*: bazel test //test/... (new test crashing without this patch) *Docs Changes*: n/a *Release Notes*: n/a Workaround for envoyproxy#3953. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
lizan
reviewed
Jul 26, 2018
| "2"); | ||
| test_server_->waitForCounterGe("listener_manager.listener_create_success", 2); | ||
|
|
||
| // Update existing RDS (no changes). |
There was a problem hiding this comment.
If this is an update with changes, I think it still crash on https://github.com/PiotrSikora/envoy/blob/a5d68d41fb0323265302c04f40493c8a3d2a2c02/source/common/router/rds_impl.cc#L121
There was a problem hiding this comment.
You're right... I could swear that I tested this locally before, but it's indeed crashing there.
| @@ -97,7 +98,7 @@ Router::ConfigConstSharedPtr RdsRouteConfigProviderImpl::config() { | |||
|
|
|||
| void RdsRouteConfigProviderImpl::onConfigUpdate(const ResourceVector& resources, | |||
| const std::string& version_info) { | |||
| last_updated_ = factory_context_.systemTimeSource().currentTime(); | |||
| last_updated_ = ProdSystemTimeSource::instance_.currentTime(); | |||
There was a problem hiding this comment.
Have a TimeSource& as member variable would be slightly better.
There was a problem hiding this comment.
Yeah, I need to mock it for the //test/common/router:rds_impl_test anyway.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
Closing this, since @lizan is close having a proper fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix the underlying issue (that factory_context_ is being
referenced after being freed), but it stops Envoy from crashing.
Risk Level: Low
Testing: bazel test //test/... (new test crashing without this patch)
Docs Changes: n/a
Release Notes: n/a
Workaround for #3953.
Signed-off-by: Piotr Sikora piotrsikora@google.com