Add stats for overload manager #4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elisha Ziskind <eziskind@google.com>
| @@ -31,7 +33,9 @@ class ThresholdTriggerImpl : public OverloadAction::Trigger { | |||
|
|
|||
| } // namespace | |||
|
|
|||
| OverloadAction::OverloadAction(const envoy::config::overload::v2alpha::OverloadAction& config) { | |||
| OverloadAction::OverloadAction(const envoy::config::overload::v2alpha::OverloadAction& config, | |||
| Stats::Scope& stats_scope) | |||
There was a problem hiding this comment.
What is the planned lifetime of of this overload action? I assume the manager will be global? Will actions be global also? Just trying to understand which scope this is going to use. Will it be the global scope? If so so we need an "overload." prefix? Will it be per-listener? (Probably not).
There was a problem hiding this comment.
Actions will be global like the manager so I think it makes sense to use global scope for stats. I'll add an "overload." prefix to the stats names.
Signed-off-by: Elisha Ziskind <eziskind@google.com>
mattklein123
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following stats for monitoring the overload manager (issue #373):
Risk Level: low
Testing: unit tests
Signed-off-by: Elisha Ziskind eziskind@google.com