Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/repokitteh.sky/repokitteh.star/ et al #4945

Merged
merged 2 commits into from Nov 2, 2018
Merged

s/repokitteh.sky/repokitteh.star/ et al #4945

merged 2 commits into from Nov 2, 2018

Conversation

itayd
Copy link
Contributor

@itayd itayd commented Nov 2, 2018

Signed-off-by: Itay Donanhirsh itay@bazoo.org

Description:
Skylark was renamed to Starlark, see https://groups.google.com/forum/#!topic/starlark-go/950s29qq22M.

Risk Level:
Low

Testing:
In this PR.

Docs Changes:
Internal repokitteh.md.

Release Notes:
None

Signed-off-by: Itay Donanhirsh <itay@bazoo.org>
@itayd
Copy link
Contributor Author

itayd commented Nov 2, 2018

/rk-bless

@repokitteh-read-only
Copy link

This PR has been blessed, meaning its repokitteh changes are in effect in this PR.
This is, however, for a limitted time (1h0m0s). In order to renew the blessing, please close and reopoen this PR.

😽

Caused by: #4945 was labeled by repokitteh[bot].

see: more, trace.

@itayd
Copy link
Contributor Author

itayd commented Nov 2, 2018

/assign

@itayd
Copy link
Contributor Author

itayd commented Nov 2, 2018

/review

@repokitteh-read-only
Copy link

no reviewer specified, a PR author cannot be assigned as a reviewer.

🐱

Caused by: a #4945 (comment) was created by @itayd.

see: more, trace.

Signed-off-by: Itay Donanhirsh <itay@bazoo.org>
@itayd
Copy link
Contributor Author

itayd commented Nov 2, 2018

/rk-unbless

@mattklein123 mattklein123 merged commit 919ab97 into envoyproxy:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants