-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: similar build flags to cmake for corresponding build types (#4… #720
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7cebb0e
bazel: similar build flags to cmake for corresponding build types (#4…
htuch 2423d5f
fix_format
htuch 63a3b1c
Don't statically link system libraries.
htuch b55e524
Bump hash for CI image.
htuch f47df63
Merge remote-tracking branch 'upstream/master' into build-flags-pr
htuch 1a75897
Merge remote-tracking branch 'upstream/master' into build-flags-pr
htuch 4969692
Merge remote-tracking branch 'upstream/master' into build-flags-pr
htuch b28d32e
Remove DEBUG for fastbuild/dbg in favor of NDEBUG on opt.
htuch 619dd3c
s/strip_include_prefix/includes/g in ci/prebuilt/BUILD to avoid -Wext…
htuch e4baffe
Add --define debug_symbols=yes support.
htuch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,23 @@ | ||
package(default_visibility = ["//visibility:public"]) | ||
|
||
exports_files(["gen_sh_test_runner.sh"]) | ||
|
||
config_setting( | ||
name = "opt_build", | ||
values = {"compilation_mode": "opt"}, | ||
) | ||
|
||
config_setting( | ||
name = "fastbuild_build", | ||
values = {"compilation_mode": "fastbuild"}, | ||
) | ||
|
||
config_setting( | ||
name = "dbg_build", | ||
values = {"compilation_mode": "dbg"}, | ||
) | ||
|
||
config_setting( | ||
name = "debug_symbols", | ||
values = {"define": "debug_symbols=yes"}, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this default in bazel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.