New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: update protobuf to 3.8.0 #7510
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
With 3.8.0 changing the zlib handling again and your changes in this PR I'm wondering if zlib is required in |
Hm, I saw your comment in the bzl file. Is zlib required besides as a dependency for protobuf? If not, I think you're right, perhaps it's not needed and we can use protobuf_deps() instead. |
I think that the compressor, decompressor and quiche use zlib.
If it's possible to have these reference the zlib brought in for protobuf it would mean one less dependency to maintain but it would also wouldn't be as clear. |
I think we should stick with our own |
@asraa the |
Signed-off-by: Asra Ali <asraa@google.com>
Timed out on macOS network listener tests
Flake? We need to document the Azure test commands. |
🤷♀️ nothing to rebuild. |
/azp run envoy-macos |
Commenter does not have sufficient privileges for PR 7510 in repo envoyproxy/envoy |
/azp run envoy-macos |
Azure Pipelines successfully started running 1 pipeline(s). |
LGTM |
In addition to updating protobuf to 3.8.0, this PR also
Risk level: low/medium
Testing: bazel test //test/...