build: update build image to 98a1276049a3cf4bebc6a0343217444a8675baf8 #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, let me know if there are any issues. |
|
@htuch looks like coverage is failing: https://travis-ci.org/lyft/envoy/jobs/221897553 |
|
Will look into this early tomorrow if that's OK. |
|
Yup no problem. |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 14, 2017
After envoyproxy#747, we no longer have the BUILD_DISTINCT=1 set of dependencies in the CI image, so fix the gcovr path to solve the failures in envoyproxy#760.
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 14, 2017
After envoyproxy#747, we no longer have the BUILD_DISTINCT=1 set of dependencies in the CI image, so fix the gcovr path to solve the failures in envoyproxy#760. Also fixed a snafu in configs/configgen.sh that I hit when running Docker as non-root. It was trying to peek at the user's home directory, with no passwd entry.
|
Closing in favor of #769 |
mattklein123
pushed a commit
that referenced
this pull request
Apr 17, 2017
After #747, we no longer have the BUILD_DISTINCT=1 set of dependencies in the CI image, so fix the gcovr path to solve the failures in #760. Also fixed a snafu in configs/configgen.sh that I hit when running Docker as non-root. It was trying to peek at the user's home directory, with no passwd entry.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: in preparation of cutting v0.3 I went ahead and audited inline TODOs. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: in preparation of cutting v0.3 I went ahead and audited inline TODOs. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.