Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext_authz: allows multiple headers of same name in Denied response #8668

Merged
merged 5 commits into from
Nov 6, 2019
Merged

ext_authz: allows multiple headers of same name in Denied response #8668

merged 5 commits into from
Nov 6, 2019

Commits on Oct 18, 2019

  1. ext_authz allows multiple headers of same name 

    Enhance the ext_authz filter to allow multiple `Set-Cookie`
headers to be added by a `Denied` `Check` response.

Previously, when the `Check` response contained multiple
headers of the same name, only the last one would be applied
in the http reponse.

Fixes envoyproxy#8649

Signed-off-by: Peter Chen <pchen@pivotal.io>

Signed-off-by: Ryan Richard <rrichard@pivotal.io>
    @cfryanr
    cfryanr authored and Peter Chen committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    d4db053 View commit details
    Browse the repository at this point in the history

  2. Fix formatting in ext_authz_test.cc 

    Signed-off-by: Ryan Richard <rrichard@pivotal.io>

Signed-off-by: Peter Chen <pchen@pivotal.io>
    @cfryanr
    Peter Chen authored and cfryanr committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    ba1ff93 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Merge branch 'master' of https://github.com/envoyproxy/envoy 

    Signed-off-by: Ryan Richard <rrichard@pivotal.io>
    @cfryanr
    cfryanr committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    da34d70 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Add comments to explain why two loops 

    - Added to ext_authz.cc at the request of the PR reviewer

Signed-off-by: Ryan Richard <rrichard@pivotal.io>
    @cfryanr
    cfryanr committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    012d74a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. Merge branch 'master' of https://github.com/envoyproxy/envoy 

    Signed-off-by: Ryan Richard <rrichard@pivotal.io>
    @cfryanr
    cfryanr committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    f034f73 View commit details
    Browse the repository at this point in the history