-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
router: add REQ(header-name) header formatter #8782
router: add REQ(header-name) header formatter #8782
Conversation
Risk Level: low Testing: unit tests Doc Changes: yes Release Notes: yes Fixes envoyproxy#8683 Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have some comments, but I think this will be a nice feature to have.
Also there's an implementation of StreamInfo in |
Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
I think if you merge master, the coverage test will stop failing. There were a few commits to increase coverage not long after you branched. |
…o_additional_resp_headers Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@dio can you have a look as well?
…o_additional_resp_headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
request_headers_to_add and response_headers_to_add can now use "%REQ(header-name)%"
Use cases:
Risk Level: low
Testing: unit tests
Doc Changes: yes
Release Notes: yes
Fixes #8683