Add response flags into cel expression context #8827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
kyessenov
reviewed
Oct 31, 2019
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
kyessenov
reviewed
Oct 31, 2019
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
kyessenov
previously approved these changes
Oct 31, 2019
|
@lizan ptal? Thanks! |
lizan
approved these changes
Nov 4, 2019
lizan
suggested changes
Nov 4, 2019
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
lizan
approved these changes
Nov 5, 2019
bianpengyuan
added a commit
to bianpengyuan/envoy
that referenced
this pull request
Nov 5, 2019
Description: Add response flags into expression context Risk Level: low Testing: unit test Docs Changes: Release Notes: Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
kyessenov
added a commit
to istio/envoy
that referenced
this pull request
Nov 6, 2019
Add response flags into cel expression context (envoyproxy#8827)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Add response flags into expression context
Risk Level: low
Testing: unit test
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]
cc @kyessenov