Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated words #9569

Closed
wants to merge 1 commit into from
Closed

Remove duplicated words #9569

wants to merge 1 commit into from

Conversation

longkb
Copy link
Contributor

@longkb longkb commented Jan 6, 2020

Although it is spelling mistakes, it might make an affects while reading.

Signed-off-by: Kim Bao Long longkb@vn.fujitsu.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

@mattklein123
Copy link
Member

Needs master merge, thanks.

/wait

@moderation
Copy link
Contributor

@longkb We should note there has been a history of small spelling change PRs being submitted one at a time in order to game Github statistics. If there are more than one PR, please batch into a larger PR for review.

@longkb
Copy link
Contributor Author

longkb commented Jan 7, 2020

Needs master merge, thanks.

/wait

Oops, sorry. I have worked in older version of repo. I will update my PR with master code :)
Thank you so much!

@longkb
Copy link
Contributor Author

longkb commented Jan 7, 2020

@longkb We should note there has been a history of small spelling change PRs being submitted one at a time in order to game Github statistics. If there are more than one PR, please batch into a larger PR for review.

Yes, I see. I will check these duplicated words agains and update if necessary :)
Thank you so much!

@repokitteh-read-only repokitteh-read-only bot added api and removed waiting labels Jan 7, 2020
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #9569 was synchronize by longkb.

see: more, trace.

Although it is spelling mistakes, it might make an affects while reading.

Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a simple check_format regex to scan for this? The script uses Python regexes, https://docs.python.org/3/library/re.html provides the examples of (.+) \1 as a regex for picking out the the. It won't work across lines, but it would probably catch a lot of the main issues here.

@htuch htuch self-assigned this Jan 7, 2020
@mattklein123
Copy link
Member

Can we add a simple check_format regex to scan for this? The script uses Python regexes, https://docs.python.org/3/library/re.html provides the examples of (.+) \1 as a regex for picking out the the. It won't work across lines, but it would probably catch a lot of the main issues here.

+1. This would be a truly valuable contribution vs. just gaming the commit stats. Thanks!

/wait

@stale
Copy link

stale bot commented Jan 14, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 14, 2020
@stale
Copy link

stale bot commented Jan 21, 2020

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api stale stalebot believes this issue/PR has not been touched recently waiting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants