api listener: add shutdown method and call during server termination #9959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 6, 2020 16:15
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
junr03
commented
Feb 7, 2020
mattklein123
requested changes
Feb 7, 2020
|
@mattklein123 updated. Thanks! |
mattklein123
requested changes
Feb 7, 2020
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Feb 10, 2020
Bumping to include the following fixes: - `dns: destroy/reinitialize c-ares channel on ARES_ECONNREFUSED`: envoyproxy/envoy#9899. This should resolve the issues we've been seeing with Envoy Mobile hanging on startup and never properly issuing requests if started in the offline state on iOS. Fixes #672, though more improvements to DNS resolution will be investigated in #673 - `gzip: add force load factory declaration`: envoyproxy/envoy#9942. This will allow us to use the gzip filter with Envoy Mobile - `api listener: add shutdown method and call during server termination`: envoyproxy/envoy#9959. Fixes #667. Fixes #674 Includes the following PRs to fix iOS liveliness tests as well: - `metrics service: force link v2 config`: envoyproxy/envoy#9875 - `config: remove ApiTypeOracle assert`: envoyproxy/envoy#9973 Also contains necessary updates to accommodate [this change](envoyproxy/envoy@dea4eb0). Signed-off-by: Michael Rebello <me@michaelrebello.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Bumping to include the following fixes: - `dns: destroy/reinitialize c-ares channel on ARES_ECONNREFUSED`: #9899. This should resolve the issues we've been seeing with Envoy Mobile hanging on startup and never properly issuing requests if started in the offline state on iOS. Fixes envoyproxy/envoy-mobile#672, though more improvements to DNS resolution will be investigated in envoyproxy/envoy-mobile#673 - `gzip: add force load factory declaration`: #9942. This will allow us to use the gzip filter with Envoy Mobile - `api listener: add shutdown method and call during server termination`: #9959. Fixes envoyproxy/envoy-mobile#667. Fixes envoyproxy/envoy-mobile#674 Includes the following PRs to fix iOS liveliness tests as well: - `metrics service: force link v2 config`: #9875 - `config: remove ApiTypeOracle assert`: #9973 Also contains necessary updates to accommodate [this change](dea4eb0). Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Bumping to include the following fixes: - `dns: destroy/reinitialize c-ares channel on ARES_ECONNREFUSED`: #9899. This should resolve the issues we've been seeing with Envoy Mobile hanging on startup and never properly issuing requests if started in the offline state on iOS. Fixes envoyproxy/envoy-mobile#672, though more improvements to DNS resolution will be investigated in envoyproxy/envoy-mobile#673 - `gzip: add force load factory declaration`: #9942. This will allow us to use the gzip filter with Envoy Mobile - `api listener: add shutdown method and call during server termination`: #9959. Fixes envoyproxy/envoy-mobile#667. Fixes envoyproxy/envoy-mobile#674 Includes the following PRs to fix iOS liveliness tests as well: - `metrics service: force link v2 config`: #9875 - `config: remove ApiTypeOracle assert`: #9973 Also contains necessary updates to accommodate [this change](dea4eb0). Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: this PR adds a shutdown method to the ApiListener and calls it where appropriate during server termination. Previously there would be a crash due to use after free of objects in thread local storage by streams in the ApiListener. Funny enough the flakes reported in #9746 happened due to this.
Risk Level: low
Testing: new unit and integration test. Without appropriate termination the new integration test repros the stacktrace reported in #9746.
Signed-off-by: Jose Nino jnino@lyft.com