fix: null pointer when CORS maxAge is not specified (#2133)

fix nullpointer Signed-off-by: huabing zhao <zhaohuabing@gmail.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
envoyproxy · Nov 1, 2023 · 35c4fea · 35c4fea
1 parent defed57
commit 35c4fea
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/internal/xds/translator/cors.go b/internal/xds/translator/cors.go
@@ -126,7 +126,9 @@ func patchRouteWithCORSConfig(route *routev3.Route, irRoute *ir.HTTPRoute) error
 	allowMethods = strings.Join(irRoute.CORS.AllowMethods, ", ")
 	allowHeaders = strings.Join(irRoute.CORS.AllowHeaders, ", ")
 	exposeHeaders = strings.Join(irRoute.CORS.ExposeHeaders, ", ")
-	maxAge = strconv.Itoa(int(irRoute.CORS.MaxAge.Seconds()))
+	if irRoute.CORS.MaxAge != nil {
+		maxAge = strconv.Itoa(int(irRoute.CORS.MaxAge.Seconds()))
+	}
 
 	routeCfgProto := &corsv3.CorsPolicy{
 		AllowOriginStringMatch: allowOrigins,