Run all conformance tests except redirect tests (#1014)

Redirect tests are failing due to a possible issue with the way upstream conformance tests have made assumptions Skipping them for now until below issues are resolved #992 #993 #994 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
envoyproxy · Feb 9, 2023 · 38a6ddd · 38a6ddd
1 parent b668002
commit 38a6ddd
Showing 1 changed file with 15 additions and 43 deletions.
diff --git a/test/conformance/conformance_test.go b/test/conformance/conformance_test.go
@@ -13,7 +13,6 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/require"
-	"k8s.io/apimachinery/pkg/util/sets"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/client/config"
 	"sigs.k8s.io/gateway-api/apis/v1alpha2"
@@ -49,49 +48,22 @@ func TestGatewayAPIConformance(t *testing.T) {
 	}
 
 	cSuite := suite.New(suite.Options{
-		Client:                   client,
-		GatewayClassName:         *flags.GatewayClassName,
-		Debug:                    *flags.ShowDebug,
-		CleanupBaseResources:     *flags.CleanupBaseResources,
-		ValidUniqueListenerPorts: validUniqueListenerPorts,
-		SupportedFeatures: sets.New(
-			suite.SupportHTTPRouteQueryParamMatching,
-			suite.SupportReferenceGrant,
-			suite.SupportHTTPResponseHeaderModification,
-			suite.SupportHTTPRouteMethodMatching,
-			suite.SupportRouteDestinationPortMatching,
-			suite.SupportGatewayClassObservedGenerationBump,
-		),
+		Client:                     client,
+		GatewayClassName:           *flags.GatewayClassName,
+		Debug:                      *flags.ShowDebug,
+		CleanupBaseResources:       *flags.CleanupBaseResources,
+		ValidUniqueListenerPorts:   validUniqueListenerPorts,
+		EnableAllSupportedFeatures: true,
+		SkipTests: []string{
+			// Remove once https://github.com/envoyproxy/gateway/issues/993 is fixed
+			tests.HTTPRouteRedirectPath.ShortName,
+			// Remove once https://github.com/envoyproxy/gateway/issues/992 is fixed
+			tests.HTTPRouteRedirectHostAndStatus.ShortName,
+			// Remove once https://github.com/envoyproxy/gateway/issues/994 is fixed
+			tests.HTTPRouteRedirectScheme.ShortName,
+		},
 	})
 	cSuite.Setup(t)
-	egTests := []suite.ConformanceTest{
-		tests.HTTPRouteSimpleSameNamespace,
-		tests.HTTPRouteRequestHeaderModifier,
-		tests.HTTPRouteResponseHeaderModifier,
-		tests.HTTPRouteQueryParamMatching,
-		tests.HTTPRouteInvalidCrossNamespaceParentRef,
-		tests.HTTPExactPathMatching,
-		tests.HTTPRouteCrossNamespace,
-		tests.HTTPRouteHeaderMatching,
-		tests.HTTPRouteMethodMatching,
-		tests.HTTPRouteMatching,
-		tests.HTTPRouteMatchingAcrossRoutes,
-		tests.HTTPRouteHostnameIntersection,
-		tests.HTTPRouteListenerHostnameMatching,
-		tests.HTTPRouteInvalidNonExistentBackendRef,
-		tests.HTTPRouteInvalidBackendRefUnknownKind,
-		tests.HTTPRouteInvalidCrossNamespaceBackendRef,
-		tests.GatewaySecretReferenceGrantAllInNamespace,
-		tests.GatewaySecretReferenceGrantSpecific,
-		tests.GatewaySecretMissingReferenceGrant,
-		tests.GatewaySecretInvalidReferenceGrant,
-		tests.GatewayInvalidTLSConfiguration,
-		tests.GatewayInvalidRouteKind,
-		tests.GatewayClassObservedGenerationBump,
-		tests.HTTPRouteReferenceGrant,
-		tests.HTTPRoutePartiallyInvalidViaInvalidReferenceGrant,
-		tests.HTTPRouteInvalidParentRefNotMatchingListenerPort,
-	}
-	cSuite.Run(t, egTests)
+	cSuite.Run(t, tests.ConformanceTests)
 
 }