Add GRPCRoute to SupportedKinds (#990)

Fixes: #950 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
envoyproxy · Feb 8, 2023 · beb6eae · beb6eae
1 parent d01daec
commit beb6eae
Show file tree

Hide file tree

Showing 103 changed files with 244 additions and 363 deletions.
diff --git a/internal/gatewayapi/listener.go b/internal/gatewayapi/listener.go
@@ -56,8 +56,7 @@ func (t *Translator) ProcessListeners(gateways []*GatewayContext, xdsIR XdsIRMap
 			case v1beta1.TLSProtocolType:
 				t.validateAllowedRoutes(listener, KindTLSRoute)
 			case v1beta1.HTTPProtocolType, v1beta1.HTTPSProtocolType:
-				// Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-				t.validateAllowedRoutes(listener, KindHTTPRoute) // , KindGRPCRoute)
+				t.validateAllowedRoutes(listener, KindHTTPRoute, KindGRPCRoute)
 			case v1beta1.TCPProtocolType:
 				t.validateAllowedRoutes(listener, KindTCPRoute)
 			case v1beta1.UDPProtocolType:

diff --git a/internal/gatewayapi/testdata/envoyproxy-valid.out.yaml b/internal/gatewayapi/testdata/envoyproxy-valid.out.yaml
@@ -19,9 +19,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute
           attachedRoutes: 0
           conditions:
             - type: Programmed

diff --git a/internal/gatewayapi/testdata/gateway-allows-same-namespace-with-allowed-httproute.out.yaml b/internal/gatewayapi/testdata/gateway-allows-same-namespace-with-allowed-httproute.out.yaml
@@ -19,9 +19,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 1
           conditions:
             - type: Programmed

diff --git a/...rnal/gatewayapi/testdata/gateway-allows-same-namespace-with-disallowed-httproute.out.yaml b/...rnal/gatewayapi/testdata/gateway-allows-same-namespace-with-disallowed-httproute.out.yaml
@@ -19,9 +19,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute        
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute        
       attachedRoutes: 0
       conditions:
       - type: Programmed

diff --git a/...tewayapi/testdata/gateway-with-listener-with-invalid-allowed-namespaces-selector.out.yaml b/...tewayapi/testdata/gateway-with-listener-with-invalid-allowed-namespaces-selector.out.yaml
@@ -25,9 +25,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 0
           conditions:
             - type: Programmed

diff --git a/internal/gatewayapi/testdata/gateway-with-listener-with-invalid-allowed-routes-kind.out.yaml b/internal/gatewayapi/testdata/gateway-with-listener-with-invalid-allowed-routes-kind.out.yaml
@@ -25,7 +25,7 @@ gateways:
             - type: ResolvedRefs
               status: "False"
               reason: InvalidRouteKinds
-              message: "FooRoute is not supported, kind must be one of [HTTPRoute]"
+              message: "FooRoute is not supported, kind must be one of [HTTPRoute GRPCRoute]"
             - type: Programmed
               status: "False"
               reason: Invalid

diff --git a/...ayapi/testdata/gateway-with-listener-with-invalid-tls-configuration-invalid-mode.out.yaml b/...ayapi/testdata/gateway-with-listener-with-invalid-tls-configuration-invalid-mode.out.yaml
@@ -24,9 +24,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 0
           conditions:
             - type: Programmed

diff --git a/...estdata/gateway-with-listener-with-invalid-tls-configuration-no-certificate-refs.out.yaml b/...estdata/gateway-with-listener-with-invalid-tls-configuration-no-certificate-refs.out.yaml
@@ -21,9 +21,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 0
           conditions:
             - type: Programmed

diff --git a/...tdata/gateway-with-listener-with-invalid-tls-configuration-secret-does-not-exist.out.yaml b/...tdata/gateway-with-listener-with-invalid-tls-configuration-secret-does-not-exist.out.yaml
@@ -23,9 +23,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 0
           conditions:
             - type: ResolvedRefs

diff --git a/...a/gateway-with-listener-with-invalid-tls-configuration-secret-in-other-namespace.out.yaml b/...a/gateway-with-listener-with-invalid-tls-configuration-secret-in-other-namespace.out.yaml
@@ -24,9 +24,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 0
           conditions:
             - type: ResolvedRefs

diff --git a/...estdata/gateway-with-listener-with-invalid-tls-configuration-secret-is-not-valid.out.yaml b/...estdata/gateway-with-listener-with-invalid-tls-configuration-secret-is-not-valid.out.yaml
@@ -23,9 +23,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 0
           conditions:
             - type: ResolvedRefs

diff --git a/...tewayapi/testdata/gateway-with-listener-with-missing-allowed-namespaces-selector.out.yaml b/...tewayapi/testdata/gateway-with-listener-with-missing-allowed-namespaces-selector.out.yaml
@@ -19,9 +19,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 0
           conditions:
             - type: Programmed

diff --git a/...ata/gateway-with-listener-with-tls-secret-in-other-namespace-allowed-by-refgrant.out.yaml b/...ata/gateway-with-listener-with-tls-secret-in-other-namespace-allowed-by-refgrant.out.yaml
@@ -24,9 +24,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 1
           conditions:
             - type: Programmed

diff --git a/...nal/gatewayapi/testdata/gateway-with-listener-with-tls-terminate-and-passthrough.out.yaml b/...nal/gatewayapi/testdata/gateway-with-listener-with-tls-terminate-and-passthrough.out.yaml
@@ -43,9 +43,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 1
           conditions:
             - type: Programmed

diff --git a/internal/gatewayapi/testdata/gateway-with-listener-with-valid-tls-configuration.out.yaml b/internal/gatewayapi/testdata/gateway-with-listener-with-valid-tls-configuration.out.yaml
@@ -23,9 +23,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           attachedRoutes: 1
           conditions:
             - type: Programmed

diff --git a/internal/gatewayapi/testdata/gateway-with-preexisting-status-condition.out.yaml b/internal/gatewayapi/testdata/gateway-with-preexisting-status-condition.out.yaml
@@ -19,9 +19,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute
           attachedRoutes: 1
           conditions:
             - type: Programmed

diff --git a/internal/gatewayapi/testdata/gateway-with-stale-status-condition.out.yaml b/internal/gatewayapi/testdata/gateway-with-stale-status-condition.out.yaml
@@ -23,9 +23,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute
           attachedRoutes: 1
           conditions:
             - type: Programmed

diff --git a/...estdata/gateway-with-two-listeners-with-http-and-tlsroute-same-hostname-and-port.out.yaml b/...estdata/gateway-with-two-listeners-with-http-and-tlsroute-same-hostname-and-port.out.yaml
@@ -29,9 +29,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute        
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute        
       conditions:
       - type: Conflicted
         status: "True"

diff --git a/internal/gatewayapi/testdata/gateway-with-two-listeners-with-multiple-httproutes.out.yaml b/internal/gatewayapi/testdata/gateway-with-two-listeners-with-multiple-httproutes.out.yaml
@@ -27,9 +27,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute        
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute        
       AttachedRoutes: 2
       conditions:
       - type: Programmed
@@ -40,9 +39,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute        
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute        
       AttachedRoutes: 2
       conditions:
       - type: Programmed

diff --git a/internal/gatewayapi/testdata/gateway-with-two-listeners-with-same-port-and-hostname.out.yaml b/internal/gatewayapi/testdata/gateway-with-two-listeners-with-same-port-and-hostname.out.yaml
@@ -27,9 +27,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute        
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute        
       conditions:
       - type: Conflicted
         status: "True"
@@ -43,9 +42,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute        
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute        
       conditions:
       - type: Conflicted
         status: "True"

diff --git a/...api/testdata/gateway-with-two-listeners-with-same-port-and-incompatible-protocol.out.yaml b/...api/testdata/gateway-with-two-listeners-with-same-port-and-incompatible-protocol.out.yaml
@@ -27,9 +27,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           conditions:
             - type: Conflicted
               status: "True"
@@ -43,9 +42,8 @@ gateways:
           supportedKinds:
             - group: gateway.networking.k8s.io
               kind: HTTPRoute
-              # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-              #- group: gateway.networking.k8s.io
-              #kind: GRPCRoute              
+            - group: gateway.networking.k8s.io
+              kind: GRPCRoute              
           conditions:
             - type: Conflicted
               status: "True"

diff --git a/.../gatewayapi/testdata/gateway-with-two-listeners-with-same-port-http-tcp-protocol.out.yaml b/.../gatewayapi/testdata/gateway-with-two-listeners-with-same-port-http-tcp-protocol.out.yaml
@@ -26,9 +26,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute
       AttachedRoutes: 1
       conditions:
       - type: Programmed

diff --git a/.../gatewayapi/testdata/gateway-with-two-listeners-with-same-port-http-udp-protocol.out.yaml b/.../gatewayapi/testdata/gateway-with-two-listeners-with-same-port-http-udp-protocol.out.yaml
@@ -26,9 +26,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute        
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute        
       AttachedRoutes: 1
       conditions:
       - type: Programmed

diff --git a/internal/gatewayapi/testdata/grpcroute-with-header-match.out.yaml b/internal/gatewayapi/testdata/grpcroute-with-header-match.out.yaml
@@ -19,9 +19,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute              
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute              
       attachedRoutes: 1
       conditions:
       - type: Programmed

diff --git a/internal/gatewayapi/testdata/grpcroute-with-request-header-modifier.out.yaml b/internal/gatewayapi/testdata/grpcroute-with-request-header-modifier.out.yaml
@@ -19,9 +19,8 @@ gateways:
       supportedKinds:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
-        # Uncomment when https://github.com/envoyproxy/gateway/issues/950 is fixed
-        #- group: gateway.networking.k8s.io
-        #kind: GRPCRoute              
+      - group: gateway.networking.k8s.io
+        kind: GRPCRoute              
       attachedRoutes: 1
       conditions:
       - type: Programmed