Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically setup containerPorts in proxy infrastructure #1032

Closed
arkodg opened this issue Feb 10, 2023 · 3 comments
Closed

Dynamically setup containerPorts in proxy infrastructure #1032

arkodg opened this issue Feb 10, 2023 · 3 comments
Assignees
@shawnh2
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. good first issue Good for newcomers kind/bug Something isn't working

Comments

@arkodg
Copy link
Contributor

arkodg commented Feb 10, 2023

Description:
The proxy infrastructure is currently statically creating containerPorts for the managed envoy proxy deployment

gateway/internal/infrastructure/kubernetes/proxy_deployment.go

Line 193 in 17d325d

ports := []corev1.ContainerPort{

These should be dynamically set based on the IR

gateway/internal/ir/infra.go

Line 55 in 17d325d

type ProxyListener struct {

This is a cosmetic bug, containerPort is purely informational

relates to #997 (comment)
@arkodg arkodg added kind/bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. labels Feb 10, 2023
@shawnh2
Copy link
Contributor

shawnh2 commented Mar 15, 2023

Hi, is this task still available? I'm willing to take it.

@shawnh2 shawnh2 mentioned this issue Mar 15, 2023
Merged
@arkodg arkodg removed the help wanted Extra attention is needed label Mar 15, 2023
@muyuan0
Copy link
Contributor

muyuan0 commented Mar 23, 2023

Consider solved?

@zirain
Copy link
Contributor

zirain commented Mar 23, 2023

fixed by #1157

@zirain zirain closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnh2 shawnh2

Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zirain @arkodg @shawnh2 @muyuan0