refactor infrastructure and add ratelimit tests.

[qicz]

• separate infrastructure configmap, service, and service account logic to proxy_xx and ratelimit_xx modules for easy maintenance. refactor ratelimit logic in infrastructure. #1008
• support Add tests for RateLimitInfra #941

[codecov-commenter]

Codecov Report

Merging #997 (586c621) into main (1b26380) will increase coverage by 2.68%.
The diff coverage is 84.63%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
+ Coverage   61.98%   64.66%   +2.68%     
==========================================
  Files          55       67      +12     
  Lines        8804     8802       -2     
==========================================
+ Hits         5457     5692     +235     
+ Misses       2972     2733     -239     
- Partials      375      377       +2     

Impacted Files	Coverage Δ
internal/infrastructure/kubernetes/configmap.go	74.07% <ø> (+20.14%)	⬆️
internal/infrastructure/kubernetes/deployment.go	67.85% <ø> (+12.88%)	⬆️
internal/infrastructure/kubernetes/infra.go	100.00% <ø> (+72.36%)	⬆️
internal/infrastructure/kubernetes/labels.go	100.00% <ø> (+22.22%)	⬆️
...ernal/infrastructure/kubernetes/ratelimit_infra.go	0.00% <0.00%> (ø)
internal/infrastructure/kubernetes/service.go	58.62% <ø> (+17.80%)	⬆️
...ternal/infrastructure/kubernetes/serviceaccount.go	58.62% <ø> (ø)
internal/message/watchutil.go	100.00% <ø> (ø)
internal/infrastructure/kubernetes/proxy_infra.go	43.24% <43.24%> (ø)
...nternal/infrastructure/kubernetes/proxy_service.go	73.33% <73.33%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[arkodg]

hey @qicz thanks for looking into this, the refactor sgtm, would reccomend also renaming existing files into proxy_X.go
lastly a good way to test out your changes would be to get the tests for these methods in, avoiding any regression. I plan on working on #941 soon but haven't started yet, is this something you can pick up ?

[qicz]

hey @qicz thanks for looking into this, the refactor sgtm, would reccomend also renaming existing files into proxy_X.go lastly a good way to test out your changes would be to get the tests for these methods in, avoiding any regression. I plan on working on #941 soon but haven't started yet, is this something you can pick up ?

Let me try to do it

[Xunzhuo]

Assigned to you @qicz, thanks!

[qicz]

@arkodg @Xunzhuo I did it pls review this.

[Xunzhuo]

Great job @qicz, I will take a look ASAP.

[arkodg]

hey @qicz thanks for picking up #941 , left comments

[arkodg]

LGTM thanks @qicz !