Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluralize backendRefs for non xRoute BackendRef #3091

Closed
3 tasks done
arkodg opened this issue Apr 4, 2024 · 16 comments
Closed
3 tasks done

Pluralize backendRefs for non xRoute BackendRef #3091

arkodg opened this issue Apr 4, 2024 · 16 comments
Assignees
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Apr 4, 2024

non xRoute backendRef may need to be pluralized in case we want to handle Active / Standby cases. These are

Originally posted by @arkodg in #3055 (comment)

@arkodg arkodg added the kind/decision A record of a decision made by the community. label Apr 4, 2024
@arkodg
Copy link
Contributor Author

arkodg commented Apr 4, 2024

ptal @envoyproxy/gateway-maintainers

@guydc
Copy link
Contributor

guydc commented Apr 4, 2024

+1

@arkodg
Copy link
Contributor Author

arkodg commented Apr 4, 2024

some more thoughts

  • if we care only about the active and passive use case, another backupBackendRef will suffice
  • If we also want traffic splitting, we'll have to pluralize backendRef

@arkodg
Copy link
Contributor Author

arkodg commented Apr 5, 2024

+1 for this

@zhaohuabing
Copy link
Member

zhaohuabing commented Apr 5, 2024

I think it's valid for non-k8s deployments, but not necessarily for k8s environment because you normally won't deploy two services for ext auth/ext proc/Telemetry.

@arkodg
Copy link
Contributor Author

arkodg commented Apr 5, 2024

@zhaohuabing even for the K8s there could be a Service local in the cluster and another Service ( on standby ) in another cluster represented as a ServiceImport

@zhaohuabing
Copy link
Member

Yah, falling back to a remote cluster is a very persuasive case for me. +1 for this!

@zirain
Copy link
Contributor

zirain commented Apr 5, 2024

for OpenTelemetry,

  1. accesslog and metric support multi sinks
  2. tracing only support one backend

@arkodg
Copy link
Contributor Author

arkodg commented Apr 5, 2024

@zirain this is more about endpoint routing for a single request - traffic spitting and priority, rather than sending multiple requests to multiple sinks

@AliceProxy
Copy link
Member

+1

@kflynn
Copy link
Contributor

kflynn commented Apr 9, 2024

This seems like a good idea, let's do it. 👍

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label May 10, 2024
@arkodg arkodg removed kind/decision A record of a decision made by the community. stale labels May 23, 2024
@arkodg arkodg added this to the v1.1.0-rc1 milestone May 23, 2024
@arkodg arkodg changed the title Should we pluralize backendRefs for non xRoute BackendRef Pluralize backendRefs for non xRoute BackendRef May 23, 2024
@shawnh2
Copy link
Contributor

shawnh2 commented May 30, 2024

@zirain is this finished?

@zirain zirain closed this as completed May 30, 2024
@arkodg
Copy link
Contributor Author

arkodg commented May 30, 2024

@zirain afaik we havent yet implemented backendRefs for extAuth, so reopening this issue

@arkodg arkodg reopened this May 30, 2024
@zirain
Copy link
Contributor

zirain commented Jun 1, 2024

@zirain afaik we havent yet implemented backendRefs for extAuth, so reopening this issue

It's done in #3469 or you want to remove the limitation of maxItems=1?

@zirain
Copy link
Contributor

zirain commented Jun 5, 2024

I think we can close it now, and create another one to track multi backends for ext_auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants