Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Message Service Design and Implementation #34

Closed
danehans opened this issue Apr 28, 2022 · 5 comments · Fixed by #193
Closed

Initial Message Service Design and Implementation #34

danehans opened this issue Apr 28, 2022 · 5 comments · Fixed by #193
Assignees
@LukeShu
Labels
area/message-service Issues related to Gateway's message service used for communication among components. documentation Improvements or additions to documentation help wanted Extra attention is needed kind/enhancement New feature or request
Milestone
0.2.0-rc1

Comments

@danehans
Copy link
Contributor

#16 specifies the need for a Message Service (MS) component to allow internal services to communicate while being loosely coupled. The MS details should be captured in this issue or a linked doc.
@danehans danehans changed the title [Message Service] Design a Message Service [MS] Design a Message Service Apr 28, 2022
@danehans danehans changed the title [MS] Design a Message Service [MS]Initial Message Service Design and Implementation Apr 29, 2022
@danehans danehans changed the title [MS]Initial Message Service Design and Implementation [MS] Initial Message Service Design and Implementation Apr 29, 2022
@danehans danehans added documentation Improvements or additions to documentation kind/enhancement New feature or request help wanted Extra attention is needed labels Apr 29, 2022
@danehans danehans added this to the v0 Release milestone Apr 29, 2022
@danehans danehans changed the title [MS] Initial Message Service Design and Implementation Initial Message Service Design and Implementation May 11, 2022
@danehans danehans added the area/message-service Issues related to Gateway's message service used for communication among components. label May 11, 2022
@danehans
Copy link
Contributor Author

@arkodg I assigned this issue to you based on the 5/24/22 community meeting notes. Please unassign yourself if that's not the case.

@arkodg arkodg removed the help wanted Extra attention is needed label Jun 1, 2022
@arkodg
Copy link
Contributor

arkodg commented Jun 1, 2022

Here's the initial design doc

arkodg added a commit to arkodg/gateway that referenced this issue Jun 6, 2022
@arkodg
Message Service Design
ce542d0 
Relates to envoyproxy#34

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this issue Jun 6, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 2, 2022
@danehans danehans added help wanted Extra attention is needed and removed stale labels Jul 2, 2022
@danehans danehans modified the milestones: 0.2.0-rc1, Backlog Jul 12, 2022
@danehans
Copy link
Contributor Author

I moved to backlog since the current EG design will not use a msg svc.

@danehans danehans modified the milestones: Backlog, 0.2.0-rc1 Jul 14, 2022
@LukeShu
Copy link
Contributor

LukeShu commented Jul 14, 2022

As discussed on today's call, I intend to pull out watchable.Map from Telepresence. Notable features that make it useful here compared to sync.Map are the additional .Subscribe and .SubscribeSubset methods. I may also pull out a single-value (rather than map) form from elsewhere in the Telepresence code.

@danehans danehans mentioned this issue Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukeShu LukeShu

Labels
area/message-service Issues related to Gateway's message service used for communication among components. documentation Improvements or additions to documentation help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Milestone
0.2.0-rc1
Development

Successfully merging a pull request may close this issue.

Set up watchable to communicate between components danehans/gateway
3 participants
@LukeShu @danehans @arkodg