Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest-release-check job is failing for latest commit #978

Closed
arkodg opened this issue Feb 3, 2023 · 10 comments
Closed

latest-release-check job is failing for latest commit #978

arkodg opened this issue Feb 3, 2023 · 10 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Feb 3, 2023

Description:
Seeing the job failing in this CI workflow https://github.com/envoyproxy/gateway/actions/runs/4086874092/jobs/7046696271#step:7:1
when merging #974

make[1]: *** [tools/make/lint.mk:87: latest-release-check] Error 1
[27](https://github.com/envoyproxy/gateway/actions/runs/4086874092/jobs/7046696271#step:7:28)
Latest install.yaml of eg is published with failures.
[28](https://github.com/envoyproxy/gateway/actions/runs/4086874092/jobs/7046696271#step:7:29)
make[1]: Leaving directory '/home/runner/work/gateway/gateway'
[29](https://github.com/envoyproxy/gateway/actions/runs/4086874092/jobs/7046696271#step:7:30)
make: *** [Makefile:18: _run] Error 2
[30](https://github.com/envoyproxy/gateway/actions/runs/4086874092/jobs/7046696271#step:7:31)
Error: Process completed with exit code 2.
@arkodg arkodg added the kind/bug Something isn't working label Feb 3, 2023
@arkodg arkodg changed the title latest-release-check job is failing for latest commits latest-release-check job is failing for latest commit Feb 3, 2023
@arkodg
Copy link
Contributor Author

arkodg commented Feb 3, 2023

cc @Xunzhuo

@Xunzhuo
Copy link
Member

Xunzhuo commented Feb 4, 2023

I think this is normal like coverage reports uploading failed sometimes, When creating latest release, uploading latest artifacts will use GitHub APIs and they are not always working well, so the job fails sometimes. I think we should be aware of it by the checking latest release job, and retrigger it. And it may always solve this problem by re-run this job.

@arkodg
Copy link
Contributor Author

arkodg commented Feb 6, 2023

@Xunzhuo I keep seeing the check to fail multiple times (~10-20%) , seen again here https://github.com/envoyproxy/gateway/actions/runs/4106358295/jobs/7084480277, should we just rm the check ?

@Xunzhuo
Copy link
Member

Xunzhuo commented Feb 7, 2023

IMHO, if we remove this but the uploading latest release is failed, we might not be aware of it. So before the next commit gets merged or latest release workflow runs, the latest release link might be broken. But if we keep this, we might just need to rerun the latest release workflow.

@danehans danehans added this to the 0.4.0-rc.1 milestone Feb 7, 2023
@danehans
Copy link
Contributor

danehans commented Feb 7, 2023

@Xunzhuo can you PTAL at this issue after v0.3.0. The recreate latest release job has been flaky due to the assets (install/quickstart.yaml) not being posted.

@arkodg
Copy link
Contributor Author

arkodg commented Feb 8, 2023

errors out 2/5 times
Screenshot 2023-02-07 at 5 53 01 PM

@Xunzhuo
Copy link
Member

Xunzhuo commented Feb 8, 2023

Thanks @arkodg, I will take a deep look after v0.3.0 :)

@AliceProxy
Copy link
Member

Looks like this action is passing for all commits other than non-code updates (such as docs updates)

Green: https://github.com/envoyproxy/gateway/actions/runs/4376814980
Red: https://github.com/envoyproxy/gateway/actions/runs/4367565345

@Xunzhuo Are you still able to work on this one for 0.4.0? 🙂

@Xunzhuo
Copy link
Member

Xunzhuo commented Mar 12, 2023

Not sure if it is related to non-code changes. Let me take a look after some higher priority issues.

@Xunzhuo
Copy link
Member

Xunzhuo commented Mar 17, 2023

May be fixed by #1161

/close

@Xunzhuo Xunzhuo closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants