-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest-release-check job is failing for latest commit #978
Comments
cc @Xunzhuo |
I think this is normal like coverage reports uploading failed sometimes, When creating latest release, uploading latest artifacts will use GitHub APIs and they are not always working well, so the job fails sometimes. I think we should be aware of it by the checking latest release job, and retrigger it. And it may always solve this problem by re-run this job. |
@Xunzhuo I keep seeing the check to fail multiple times (~10-20%) , seen again here https://github.com/envoyproxy/gateway/actions/runs/4106358295/jobs/7084480277, should we just rm the check ? |
IMHO, if we remove this but the uploading latest release is failed, we might not be aware of it. So before the next commit gets merged or latest release workflow runs, the latest release link might be broken. But if we keep this, we might just need to rerun the latest release workflow. |
@Xunzhuo can you PTAL at this issue after v0.3.0. The recreate latest release job has been flaky due to the assets (install/quickstart.yaml) not being posted. |
Thanks @arkodg, I will take a deep look after v0.3.0 :) |
Looks like this action is passing for all commits other than non-code updates (such as docs updates) Green: https://github.com/envoyproxy/gateway/actions/runs/4376814980 @Xunzhuo Are you still able to work on this one for 0.4.0? 🙂 |
Not sure if it is related to non-code changes. Let me take a look after some higher priority issues. |
May be fixed by #1161 /close |
Description:
Seeing the job failing in this CI workflow https://github.com/envoyproxy/gateway/actions/runs/4086874092/jobs/7046696271#step:7:1
when merging #974
The text was updated successfully, but these errors were encountered: