Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translator: refactor authn and ratelimit to use buildXdsCluster #1015

Merged
merged 5 commits into from
Feb 15, 2023
Merged

translator: refactor authn and ratelimit to use buildXdsCluster #1015

merged 5 commits into from
Feb 15, 2023

Conversation

sbko
Copy link
Contributor

@sbko sbko commented Feb 9, 2023

Fixes #979

@sbko
translator: refactors xds cluster builder for ratelimit
3114ccb 
Signed-off-by: Stanislav Bondarenko <stanislav.bondarenko@gmail.com>
@sbko
translator: refactors xds cluster builder for jwkscluster
73ee4fb 
Signed-off-by: Stanislav Bondarenko <stanislav.bondarenko@gmail.com>
@sbko sbko requested a review from a team as a code owner February 9, 2023 15:19
danehans
danehans suggested changes Feb 9, 2023
View reviewed changes
internal/xds/translator/authentication.go Outdated Show resolved Hide resolved
internal/xds/translator/authentication.go Outdated Show resolved Hide resolved
internal/xds/translator/ratelimit.go Outdated Show resolved Hide resolved
internal/xds/translator/authentication.go Outdated Show resolved Hide resolved
internal/xds/translator/authentication.go Outdated Show resolved Hide resolved
@danehans
Copy link
Contributor

danehans commented Feb 9, 2023

Moving this to 0.4 since it's not fixing a v0.3 release blocker bug.

@danehans danehans added this to the 0.4.0-rc.1 milestone Feb 9, 2023
@danehans danehans added the area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. label Feb 9, 2023
@sbko
translator: adds isStatic logic to buildXdsCluster
8db323c 
Signed-off-by: Stanislav Bondarenko <stanislav.bondarenko@gmail.com>
@sbko
translator: change jwks cluster back to static
58801c1 
Signed-off-by: Stanislav Bondarenko <stanislav.bondarenko@gmail.com>
@sbko sbko changed the title translator: refactor authn and ratelimit to use buildXdsCluster WIP: translator: refactor authn and ratelimit to use buildXdsCluster Feb 10, 2023
@sbko
refactors routeContainsJwtAuthn
a14b356 
Signed-off-by: Stanislav Bondarenko <stanislav.bondarenko@gmail.com>
arkodg
arkodg approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the comments !

@sbko sbko changed the title WIP: translator: refactor authn and ratelimit to use buildXdsCluster translator: refactor authn and ratelimit to use buildXdsCluster Feb 11, 2023
@sbko sbko requested a review from danehans February 11, 2023 01:11
@arkodg
Copy link
Contributor

arkodg commented Feb 14, 2023

@danehans can you ptal ?

@danehans danehans merged commit 4262398 into envoyproxy:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danehans danehans danehans approved these changes

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR.
Projects
None yet
Milestone
0.4.0-rc.1
Development

Successfully merging this pull request may close these issues.

Refactor authn and ratelimit features to reuse buildXdsCluster
3 participants
@sbko @danehans @arkodg