-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate user config #1028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bing Han <h.bing612@gmail.com>
arkodg
reviewed
Feb 10, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1028 +/- ##
==========================================
+ Coverage 62.03% 64.93% +2.89%
==========================================
Files 55 67 +12
Lines 8804 8730 -74
==========================================
+ Hits 5462 5669 +207
+ Misses 2967 2689 -278
+ Partials 375 372 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Feb 15, 2023
Signed-off-by: Bing Han <h.bing612@gmail.com>
2bd2085
to
36e6f9a
Compare
Signed-off-by: Bing Han <h.bing612@gmail.com>
arkodg
reviewed
Feb 15, 2023
Signed-off-by: Bing Han <h.bing612@gmail.com>
arkodg
approved these changes
Feb 16, 2023
LGTM, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bing Han h.bing612@gmail.com
Move the cfg.Validate below to validate user config. Without this fix, the test will fail: