Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support egctl x translate -f - #1065

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Feb 21, 2023

Fixes: #1057

Fixes: envoyproxy#1057

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner February 21, 2023 00:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #1065 (b39b021) into main (2c57f3d) will decrease coverage by 0.24%.
The diff coverage is 36.36%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
- Coverage   64.33%   64.10%   -0.24%     
==========================================
  Files          70       70              
  Lines        9012     9032      +20     
==========================================
- Hits         5798     5790       -8     
- Misses       2820     2843      +23     
- Partials      394      399       +5     
Impacted Files Coverage Δ
internal/cmd/egctl/translate.go 66.98% <36.36%> (-3.86%) ⬇️
internal/provider/kubernetes/helpers.go 81.08% <0.00%> (-2.71%) ⬇️
internal/provider/kubernetes/controller.go 49.66% <0.00%> (-1.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xunzhuo Xunzhuo merged commit b97859d into envoyproxy:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to get input from stdin in egctl x translate
3 participants