feat: make egctl x translate output struct #1066

Xunzhuo · 2023-02-21T11:38:02Z

Resolved: #1055

internal/cmd/egctl/translate.go

codecov-commenter · 2023-02-22T08:37:56Z

Codecov Report

Merging #1066 (cc3f8bd) into main (b97859d) will decrease coverage by 0.33%.
The diff coverage is 53.94%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
- Coverage   64.29%   63.97%   -0.33%     
==========================================
  Files          70       70              
  Lines        9032     9154     +122     
==========================================
+ Hits         5807     5856      +49     
- Misses       2829     2891      +62     
- Partials      396      407      +11

Impacted Files	Coverage Δ
internal/cmd/egctl/version.go	`0.00% <0.00%> (ø)`
internal/cmd/egctl/translate.go	`60.36% <54.30%> (-6.62%)`	⬇️
internal/provider/kubernetes/helpers.go	`80.40% <0.00%> (-2.71%)`	⬇️
internal/provider/kubernetes/controller.go	`50.90% <0.00%> (-0.34%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

docs/latest/user/egctl.md

internal/cmd/egctl/testdata/out/from-gateway-api-to-xds.out

internal/cmd/egctl/testdata/out/from-gateway-api-to-xds.json.out

internal/cmd/egctl/translate_test.go

arkodg · 2023-02-22T20:03:56Z

internal/cmd/egctl/translate.go

+		}
+	case "cluster":
+		for _, config := range globalConfigs.Configs {
+			if config.GetTypeUrl() == "type.googleapis.com/envoy.admin.v3.ClustersConfigDump" {


any magic constants for these in go-contol-plane ?

internal/cmd/egctl/translate.go

Signed-off-by: bitliu <bitliu@tencent.com>

arkodg · 2023-02-23T18:33:45Z

internal/cmd/egctl/translate.go

@@ -55,6 +58,8 @@ func NewTranslateCommand() *cobra.Command {
 	}
 	translateCommand.PersistentFlags().StringVarP(&inType, "from", "", gatewayAPIType, getValidInputTypesStr())
 	translateCommand.PersistentFlags().StringVarP(&outType, "to", "", xdsType, getValidOutputTypesStr())
+	translateCommand.PersistentFlags().StringVarP(&output, "output", "o", yamlOutput, "One of 'yaml' or 'json'")
+	translateCommand.PersistentFlags().StringVarP(&resourceType, "type", "t", string(AllEnvoyConfigType), getValidResourceTypesStr())


--type here is tied to --to, currently it only represent xds type, it might need to be removed in the future or reframed to output types and then list out all valid types per output

arkodg

LGTM thanks !

Xunzhuo requested a review from a team as a code owner February 21, 2023 11:38

Xunzhuo force-pushed the feat-x-cmd branch from 973ce27 to 42852c1 Compare February 21, 2023 11:38

zirain reviewed Feb 21, 2023

View reviewed changes

internal/cmd/egctl/translate.go Outdated Show resolved Hide resolved

Xunzhuo force-pushed the feat-x-cmd branch 4 times, most recently from fd9b252 to 5c5697c Compare February 22, 2023 08:35

Xunzhuo force-pushed the feat-x-cmd branch from 5c5697c to a44b9c5 Compare February 22, 2023 09:07