Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move bootstrap gen into its own xds package #1079

Merged
merged 1 commit into from Feb 28, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Feb 28, 2023

No description provided.

@arkodg arkodg requested a review from a team as a code owner February 28, 2023 01:04
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@codecov-commenter
Copy link

Codecov Report

Merging #1079 (bb3db9d) into main (ec76243) will decrease coverage by 0.03%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1079      +/-   ##
==========================================
- Coverage   64.35%   64.33%   -0.03%     
==========================================
  Files          70       70              
  Lines        9134     9106      -28     
==========================================
- Hits         5878     5858      -20     
+ Misses       2853     2848       -5     
+ Partials      403      400       -3     
Impacted Files Coverage Δ
internal/cmd/egctl/translate.go 67.57% <75.00%> (ø)
...rnal/infrastructure/kubernetes/proxy_deployment.go 91.07% <100.00%> (+1.78%) ⬆️
internal/provider/kubernetes/helpers.go 78.37% <0.00%> (-5.41%) ⬇️
internal/provider/kubernetes/controller.go 51.01% <0.00%> (+1.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zirain zirain merged commit 167e718 into envoyproxy:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants