Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add examples of egctl x translate examples #1084

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Feb 28, 2023

image

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo marked this pull request as ready for review February 28, 2023 09:18
@Xunzhuo Xunzhuo requested a review from a team as a code owner February 28, 2023 09:18
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Feb 28, 2023

cc @zirain

@Xunzhuo Xunzhuo added this to the 0.4.0-rc.1 milestone Feb 28, 2023
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, defer to @arkodg for another look.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@arkodg arkodg merged commit 1c9ef0f into envoyproxy:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants