Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add egctl only client version #1089

Merged
merged 3 commits into from
Mar 1, 2023
Merged

feat: add egctl only client version #1089

merged 3 commits into from
Mar 1, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Mar 1, 2023

xref: #1085

@Xunzhuo
feat: add egctl only client version
94bfd24 
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo marked this pull request as ready for review March 1, 2023 04:13
@Xunzhuo Xunzhuo requested a review from a team as a code owner March 1, 2023 04:13
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Mar 1, 2023

cc @zirain

@Xunzhuo Xunzhuo added this to the 0.4.0-rc.1 milestone Mar 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023 •
edited
Loading

Codecov Report

Merging #1089 (4547efe) into main (4dd36a5) will increase coverage by 0.04%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
+ Coverage   62.70%   62.74%   +0.04%     
==========================================
  Files          72       72              
  Lines        9424     9440      +16     
==========================================
+ Hits         5909     5923      +14     
- Misses       3111     3116       +5     
+ Partials      404      401       -3
Impacted Files Coverage Δ
internal/cmd/egctl/version.go 0.00% <0.00%> (ø)
internal/provider/kubernetes/helpers.go 83.10% <0.00%> (+1.35%) ⬆️
internal/provider/kubernetes/controller.go 51.69% <0.00%> (+1.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo
update
17e51f7 
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from zirain March 1, 2023 06:27
zirain
zirain previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with small nits.

internal/cmd/egctl/version.go Outdated Show resolved Hide resolved
internal/cmd/egctl/version.go Outdated Show resolved Hide resolved
@Xunzhuo
update
4547efe 
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from zirain March 1, 2023 06:32
zirain
zirain approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Xunzhuo Xunzhuo merged commit 08da29e into envoyproxy:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

Assignees
No one assigned
Labels
area/egctl
Projects
None yet
Milestone
0.4.0-rc.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xunzhuo @codecov-commenter @zirain