Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ADS for all xDS resources #1095

Merged
merged 1 commit into from
Mar 7, 2023
Merged

use ADS for all xDS resources #1095

merged 1 commit into from
Mar 7, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Mar 4, 2023

@arkodg arkodg requested a review from a team as a code owner March 4, 2023 00:53
@arkodg
Copy link
Contributor Author

arkodg commented Mar 4, 2023

@lizan can you ptal

@codecov-commenter
Copy link

Codecov Report

Merging #1095 (d20ef26) into main (d530bb9) will increase coverage by 0.07%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
+ Coverage   62.47%   62.54%   +0.07%     
==========================================
  Files          72       72              
  Lines        9430     9421       -9     
==========================================
+ Hits         5891     5892       +1     
+ Misses       3133     3125       -8     
+ Partials      406      404       -2     
Impacted Files Coverage Δ
internal/xds/translator/listener.go 81.34% <100.00%> (-0.50%) ⬇️
internal/provider/kubernetes/controller.go 50.33% <0.00%> (+0.56%) ⬆️
internal/provider/kubernetes/helpers.go 83.10% <0.00%> (+3.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants