Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should return before accessing the nil value r.mgr #1103

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: should return before accessing the nil value r.mgr #1103

merged 1 commit into from
Mar 6, 2023

Conversation

muyuan0
Copy link
Contributor

@muyuan0 muyuan0 commented Mar 6, 2023

No description provided.

@muyuan0
fix: should return before accesing the nil value r.mgr
71498c3 
Signed-off-by: muyuan0 <127020730+muyuan0@users.noreply.github.com>
@muyuan0 muyuan0 changed the title fix: should return before accesing the nil value r.mgr fix: should return before accessing the nil value r.mgr Mar 6, 2023
@muyuan0 muyuan0 marked this pull request as ready for review March 6, 2023 11:53
@muyuan0 muyuan0 requested a review from a team as a code owner March 6, 2023 11:53
arkodg
arkodg approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks !

@arkodg arkodg merged commit 18890ec into envoyproxy:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@muyuan0 @arkodg