chore: unify the way to create RouteDestination #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When taking a look at issue 786, I found that different places use different way to create RouteDestination. This commit unifies the behavior. Signed-off-by: muyuan0 <127020730+muyuan0@users.noreply.github.com>
|
I would like to put each field into private, but it will break the yaml marshal used in the test (in/out diff). However, we can solve it if this type of refactoring is welcome. |
arkodg
reviewed
Mar 6, 2023
internal/gatewayapi/route.go
Outdated
| Host: service.Spec.ClusterIP, | ||
| Port: uint32(*backendRef.Port), | ||
| }) | ||
| weight := uint32(0) |
There was a problem hiding this comment.
lets rm this, since it wasn't part of the orig logic
arkodg
reviewed
Mar 6, 2023
internal/gatewayapi/route.go
Outdated
| Host: service.Spec.ClusterIP, | ||
| Port: uint32(*backendRef.Port), | ||
| }) | ||
| weight := uint32(0) |
|
thanks @muyuan0 , added some comments |
Signed-off-by: muyuan0 <127020730+muyuan0@users.noreply.github.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1104 +/- ##
==========================================
+ Coverage 62.47% 62.56% +0.09%
==========================================
Files 72 72
Lines 9430 9449 +19
==========================================
+ Hits 5891 5912 +21
Misses 3133 3133
+ Partials 406 404 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Mar 7, 2023
Signed-off-by: muyuan0 <127020730+muyuan0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #786
When taking a look at issue 786, I found that different places use different way to create RouteDestination.
This commit unifies the behavior.