Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: controller-gen set webhook output path #1108

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Mar 7, 2023

xref: #1107

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo marked this pull request as ready for review March 7, 2023 02:31
@Xunzhuo Xunzhuo requested a review from a team as a code owner March 7, 2023 02:31
@codecov-commenter
Copy link

Codecov Report

Merging #1108 (d56b715) into main (18890ec) will increase coverage by 0.09%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
+ Coverage   62.55%   62.65%   +0.09%     
==========================================
  Files          72       72              
  Lines        9439     9439              
==========================================
+ Hits         5905     5914       +9     
+ Misses       3128     3121       -7     
+ Partials      406      404       -2     
Impacted Files Coverage Δ
internal/provider/kubernetes/controller.go 51.24% <0.00%> (+0.67%) ⬆️
internal/provider/kubernetes/helpers.go 80.40% <0.00%> (+2.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arkodg arkodg merged commit aadebca into envoyproxy:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants