Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation for bootstrap within EnvoyProxy res #1109

Merged
merged 5 commits into from Mar 9, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Mar 7, 2023

Relates to #31

@arkodg arkodg requested a review from a team as a code owner March 7, 2023 23:52
Relates to envoyproxy#31

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #1109 (e4bd4fe) into main (aadebca) will increase coverage by 0.04%.
The diff coverage is 60.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
+ Coverage   62.42%   62.47%   +0.04%     
==========================================
  Files          72       72              
  Lines        9430     9495      +65     
==========================================
+ Hits         5887     5932      +45     
- Misses       3136     3150      +14     
- Partials      407      413       +6     
Impacted Files Coverage Δ
api/config/v1alpha1/validation/envoyproxy.go 68.18% <60.00%> (-21.82%) ⬇️
internal/ir/xds.go 72.90% <0.00%> (-1.24%) ⬇️
internal/gatewayapi/route.go 86.33% <0.00%> (ø)
internal/ir/zz_generated.deepcopy.go 12.39% <0.00%> (+0.04%) ⬆️
internal/provider/kubernetes/controller.go 50.56% <0.00%> (+1.24%) ⬆️
internal/provider/kubernetes/helpers.go 83.10% <0.00%> (+3.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with follow up: #1116

@arkodg arkodg merged commit f76ebe0 into envoyproxy:main Mar 9, 2023
@arkodg arkodg deleted the validate-bootstrap branch March 9, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants