Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update Building doc to mention egctl #1112

Merged
merged 1 commit into from Mar 8, 2023
Merged

Conversation

muyuan0
Copy link
Contributor

@muyuan0 muyuan0 commented Mar 8, 2023

No description provided.

Signed-off-by: muyuan0 <127020730+muyuan0@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1112 (76d39c0) into main (aadebca) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
+ Coverage   62.42%   62.43%   +0.01%     
==========================================
  Files          72       72              
  Lines        9430     9430              
==========================================
+ Hits         5887     5888       +1     
+ Misses       3136     3135       -1     
  Partials      407      407              
Impacted Files Coverage Δ
internal/provider/kubernetes/helpers.go 78.37% <0.00%> (-1.36%) ⬇️
internal/provider/kubernetes/controller.go 49.66% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@muyuan0 muyuan0 marked this pull request as ready for review March 8, 2023 07:58
@muyuan0 muyuan0 requested a review from a team as a code owner March 8, 2023 07:58
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for enhancing the dev docs !

@arkodg arkodg merged commit c903255 into envoyproxy:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants