Revert "ci: add helm login to prevent authorization failed" #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c7dbbdd.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1134 +/- ##
==========================================
+ Coverage 62.75% 62.76% +0.01%
==========================================
Files 72 72
Lines 9528 9528
==========================================
+ Hits 5979 5980 +1
Misses 3137 3137
+ Partials 412 411 -1 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
It is maybe the current EG using dockerhub account id/password does not have the priviledge to create a repo when pushing and found repo is not existed. |
zirain
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1131
After docker login, we do not need to helm login anymore.
Need to create a repo called envoy-gateway in dockerhub to release helm chart.
We cannot reuse gateway / gateway-dev , preventing conflicts and overrides the same tag.
Hold after creating a new repo in dockerhub.