Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: add whitenoise check #121

Merged
merged 2 commits into from Jun 30, 2022
Merged

lint: add whitenoise check #121

merged 2 commits into from Jun 30, 2022

Conversation

daixiang0
Copy link
Member

Signed-off-by: Loong Dai loong.dai@intel.com

danehans
danehans previously approved these changes Jun 28, 2022
kflynn
kflynn previously approved these changes Jun 28, 2022
@danehans danehans changed the title lint: add whitenoice check lint: add whitenoise check Jun 29, 2022
@daixiang0 daixiang0 dismissed stale reviews from kflynn and danehans via 1f2bc4e June 30, 2022 01:43
@daixiang0 daixiang0 requested a review from danehans June 30, 2022 07:41
Signed-off-by: Loong Dai <loong.dai@intel.com>
Signed-off-by: Loong Dai <loong.dai@intel.com>
@codecov-commenter
Copy link

Codecov Report

Merging #121 (93b0b49) into main (80b78e5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            5         5           
=========================================
  Hits             5         5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b78e5...93b0b49. Read the comment docs.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg merged commit 3111995 into envoyproxy:main Jun 30, 2022
@daixiang0 daixiang0 deleted the noise branch July 1, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants