Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xds translator #123

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Xds translator #123

merged 1 commit into from
Jul 8, 2022

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jun 28, 2022 •
edited

Relates to #39

Referenced most of the code from @cpakulski's work in a similar project

@arkodg arkodg requested a review from a team as a code owner June 28, 2022 18:38
@arkodg
Copy link
Contributor Author

arkodg commented Jun 29, 2022

hitting a codespell error https://github.com/envoyproxy/gateway/runs/7103153542?check_suite_focus=true

Error: ./docs/design/CONFIG_API.md:5: motiviation ==> motivation
[25](https://github.com/envoyproxy/gateway/runs/7103153542?check_suite_focus=true#step:5:26)
Codespell found one or more problems

that should be fixed in #125
this was not caught in #95 because the CI never ran since it had md changes, looks like we need to edit

gateway/.github/workflows/build_and_test.yaml

Line 15 in d530327

- "**/*.md"

arkodg added a commit to arkodg/gateway that referenced this pull request Jun 29, 2022
@arkodg
run ci for md file changes
b16b6e5 
relates to envoyproxy#123 (comment)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit that referenced this pull request Jun 29, 2022
@arkodg
fix go mod (#125)
f95b747 
* fix go mod

* reran `go mod tidy` / `go mod vendor`

* fix spellings that was causing codespell to complain

* run ci for md file changes

relates to #123 (comment)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@danehans
Copy link
Contributor

@arkodg now that #125 has merged, rebase this PR and it should pass CI.

@arkodg arkodg requested review from lizan July 1, 2022 16:36
youngnick
youngnick previously approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I like the test structure, it seems like it should be easy to do TDD with.

@arkodg
init xDS Translator
b4fbf60 
Relates to envoyproxy#39

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from youngnick July 7, 2022 21:24
@arkodg
Copy link
Contributor Author

arkodg commented Jul 7, 2022

thanks for the review @youngnick , repushed to fix the go.mod merge conflicts, can you ptal again

@arkodg arkodg merged commit d7d8bc9 into envoyproxy:main Jul 8, 2022
@danehans danehans mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danehans danehans danehans approved these changes

@lizan lizan Awaiting requested review from lizan

@youngnick youngnick Awaiting requested review from youngnick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arkodg @danehans @youngnick