Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ratelimit): add syntax explanation for missing code block location #1331

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

aimuz
Copy link
Contributor

@aimuz aimuz commented Apr 19, 2023

Signed-off-by: aimuz mr.imuz@gmail.com

What type of PR is this?

docs(ratelimit): add syntax explanation for missing code block location

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@aimuz aimuz requested a review from a team as a code owner April 19, 2023 07:06
@@ -172,7 +172,7 @@ spec:

Here's an example highlighting this -

```
```yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Xunzhuo , will this work?

Copy link
Member

@Xunzhuo Xunzhuo Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is minor but good to go, tested locally.

image

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #1331 (ba7170f) into main (5d360cb) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   61.81%   61.86%   +0.05%     
==========================================
  Files          85       85              
  Lines       10854    10854              
==========================================
+ Hits         6709     6715       +6     
+ Misses       3700     3694       -6     
  Partials      445      445              

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arkodg arkodg merged commit 296d842 into envoyproxy:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants