docs: multiple certificates, sni based selection #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
|
should we link to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/ssl#certificate-selection for more details around certificate selection? or should we add it in our docs itself? |
Codecov Report
@@ Coverage Diff @@
## main #1381 +/- ##
==========================================
- Coverage 62.40% 62.30% -0.11%
==========================================
Files 78 78
Lines 10953 10953
==========================================
- Hits 6835 6824 -11
- Misses 3667 3676 +9
- Partials 451 453 +2 |
arkodg
reviewed
May 1, 2023
arkodg
previously approved these changes
May 1, 2023
|
also can you copy over this file into |
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Xunzhuo
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation to test SNI based selection when multiple certificates are
provided in Gateway to terminate TLS traffic. The certificate to be served is chosen
based on the SNI in the client request. The doc adds a scenario and testing steps for the same.
Fixes #1275