Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pass Status instead of entire obj in watchable #1384

Merged
merged 2 commits into from
May 2, 2023
Merged

fix: Pass Status instead of entire obj in watchable #1384

merged 2 commits into from
May 2, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented May 1, 2023

Fixes #1367

@arkodg
Pass Status instead of entire obj in watchable
81b08ec 
Fixes envoyproxy#1367

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner May 1, 2023 23:18
@codecov
Copy link

codecov bot commented May 2, 2023 •
edited
Loading

Codecov Report

Merging #1384 (37bef4f) into main (48d4bb9) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   62.32%   62.36%   +0.03%     
==========================================
  Files          78       78              
  Lines       10953    10959       +6     
==========================================
+ Hits         6827     6835       +8     
+ Misses       3674     3673       -1     
+ Partials      452      451       -1
Impacted Files Coverage Δ
internal/gatewayapi/runner/runner.go 26.00% <0.00%> (ø)
internal/message/types.go 0.00% <ø> (ø)
internal/provider/kubernetes/controller.go 49.17% <0.00%> (-0.11%) ⬇️

... and 1 file with indirect coverage changes

chauhanshubham
chauhanshubham approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@chauhanshubham chauhanshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. lgtm

AliceProxy
AliceProxy approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@AliceProxy AliceProxy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arkodg arkodg merged commit 01bd564 into envoyproxy:main May 2, 2023
@arkodg arkodg deleted the optimize-status-struct branch May 2, 2023 23:53
@arkodg arkodg mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliceProxy AliceProxy AliceProxy approved these changes

@chauhanshubham chauhanshubham chauhanshubham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass xRoute Status object instead of entire xRoute object using watchable
3 participants
@arkodg @AliceProxy @chauhanshubham