feat: add API for Deployment Mode #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to envoyproxy#1117 ``` apiVersion: config.gateway.envoyproxy.io/v1alpha1 kind: EnvoyGateway gateway: controllerName: gateway.envoyproxy.io/gatewayclass-controller provider: type: Kubernetes kubernetes: mode: watch: namespaces: - "ns-1" - "ns-2" ``` Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 62.63% 61.95% -0.68%
==========================================
Files 79 79
Lines 11116 11293 +177
==========================================
+ Hits 6962 6997 +35
- Misses 3699 3836 +137
- Partials 455 460 +5
|
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
haq204
approved these changes
May 17, 2023
|
add a label for testing |
zirain
approved these changes
May 17, 2023
tanujd11
pushed a commit
to tanujd11/gateway
that referenced
this pull request
May 20, 2023
* Add API for Deployment Mode Relates to envoyproxy#1117 ``` apiVersion: config.gateway.envoyproxy.io/v1alpha1 kind: EnvoyGateway gateway: controllerName: gateway.envoyproxy.io/gatewayclass-controller provider: type: Kubernetes kubernetes: mode: watch: namespaces: - "ns-1" - "ns-2" ``` Signed-off-by: Arko Dasgupta <arko@tetrate.io> * rm top level mode Signed-off-by: Arko Dasgupta <arko@tetrate.io> * fix Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1117