Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: try to fix permissions for cherrypick action #1439

Merged
merged 1 commit into from
May 23, 2023

Conversation

zirain
Copy link
Contributor

@zirain zirain commented May 22, 2023

default action permissions:
image

cherrypick action permissions:

image

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain requested a review from a team as a code owner May 22, 2023 08:10
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #1439 (c0a6435) into main (24208c3) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
+ Coverage   62.03%   62.12%   +0.09%     
==========================================
  Files          79       79              
  Lines       11275    11275              
==========================================
+ Hits         6994     7005      +11     
+ Misses       3824     3816       -8     
+ Partials      457      454       -3     

see 2 files with indirect coverage changes

@arkodg
Copy link
Contributor

arkodg commented May 22, 2023

so this PR reverts #1404 & #1428 ?

@zirain
Copy link
Contributor Author

zirain commented May 23, 2023

so this PR reverts #1404 & #1428 ?

yes, and this's last try, if this PR not working, I have no idea about it.

@arkodg
Copy link
Contributor

arkodg commented May 23, 2023

so this PR reverts #1404 & #1428 ?

yes, and this's last try, if this PR not working, I have no idea about it.

trying to understand how this will fix the issue

@zirain
Copy link
Contributor Author

zirain commented May 23, 2023

make the setting same as other action, expect to get same perrmissions when action setup

@Xunzhuo Xunzhuo merged commit 24f0f17 into envoyproxy:main May 23, 2023
18 checks passed
@zirain zirain deleted the cherrypick-action branch May 23, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants