Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix examples/kubernetes/envoy-proxy-config.yaml for #1232. #1444

Merged
merged 1 commit into from
May 25, 2023

Conversation

tommie
Copy link
Contributor

@tommie tommie commented May 24, 2023

What this PR does / why we need it:
#1232 changed the KubernetesDeploymentSpec layout, and the example should have been updated to match.

Which issue(s) this PR fixes:
None.

@tommie tommie requested a review from a team as a code owner May 24, 2023 09:26
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1444 (36c75a1) into main (6baaaf1) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1444      +/-   ##
==========================================
+ Coverage   61.88%   62.11%   +0.22%     
==========================================
  Files          85       79       -6     
  Lines       10852    11318     +466     
==========================================
+ Hits         6716     7030     +314     
- Misses       3692     3832     +140     
- Partials      444      456      +12     

see 56 files with indirect coverage changes

@arkodg
Copy link
Contributor

arkodg commented May 24, 2023

thanks @tommie, diff looks good, can you sign your commit, and force push, steps are here

Signed-off-by: Tommie Gannert <tommie@gannert.se>
@tommie
Copy link
Contributor Author

tommie commented May 24, 2023

Done. Cheers.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this

@zirain zirain merged commit 5ef95ff into envoyproxy:main May 25, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants