Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update gateway api crds in testdata for v0.7.0 #1445

Merged
merged 2 commits into from
May 25, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented May 24, 2023

No description provided.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner May 24, 2023 17:43
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1445 (062d896) into main (3344221) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1445      +/-   ##
==========================================
+ Coverage   61.98%   62.00%   +0.02%     
==========================================
  Files          79       79              
  Lines       11318    11318              
==========================================
+ Hits         7015     7018       +3     
+ Misses       3844     3841       -3     
  Partials      459      459              

see 1 file with indirect coverage changes

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

should make these as part of in make generate?

@arkodg
Copy link
Contributor Author

arkodg commented May 25, 2023

/lgtm

should make these as part of in make generate?

good point

@Xunzhuo Xunzhuo merged commit 5dc86b8 into envoyproxy:main May 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants