Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support EndpointSlice in Kubernetes Provider #1474

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jun 1, 2023

  • Reconcile relavant EndpointSlices associated with a Service that is referenced in a xRoute
  • Add the EndpointSlices to the provider message

Relates to #1256

* Reconcile relavant EndpointSlices associated with a
Service that is referenced in a xRoute
* Add the EndpointSlices to the provider message

Relates to envoyproxy#1256

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner June 1, 2023 19:22
@arkodg arkodg mentioned this pull request Jun 1, 2023
3 tasks
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #1474 (c84c3cc) into main (22bd06b) will increase coverage by 0.18%.
The diff coverage is 49.18%.

@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
+ Coverage   61.40%   61.58%   +0.18%     
==========================================
  Files          79       79              
  Lines       11459    11545      +86     
==========================================
+ Hits         7036     7110      +74     
- Misses       3962     3970       +8     
- Partials      461      465       +4     
Impacted Files Coverage Δ
internal/gatewayapi/resource.go 51.51% <0.00%> (-1.61%) ⬇️
internal/gatewayapi/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
internal/provider/kubernetes/controller.go 50.00% <48.00%> (+0.11%) ⬆️
internal/provider/kubernetes/predicates.go 56.33% <69.23%> (+0.56%) ⬆️

... and 4 files with indirect coverage changes

@zirain
Copy link
Contributor

zirain commented Jun 2, 2023

this's only part of #1256?

@arkodg
Copy link
Contributor Author

arkodg commented Jun 2, 2023

this's only part of #1256?

yes, we need to take this data, and parse it in gateway api library which I plan on doing in a follow up PR

@zirain
Copy link
Contributor

zirain commented Jun 2, 2023

this's only part of #1256?

yes, we need to take this data, and parse it in gateway api library which I plan on doing in a follow up PR

what about endpoint, I know it will EOL soon, but in real world people always running old version kubernetes.

@arkodg
Copy link
Contributor Author

arkodg commented Jun 2, 2023

this's only part of #1256?

yes, we need to take this data, and parse it in gateway api library which I plan on doing in a follow up PR

what about endpoint, I know it will EOL soon, but in real world people always running old version kubernetes.

currently we only support last 3 k8s versions
https://gateway.envoyproxy.io/v0.4.0/intro/compatibility.html#compatibility-matrix
by the time we GA, my guess is most users will be using k8s versions with endpointslice enabled

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@zirain
Copy link
Contributor

zirain commented Jun 3, 2023

this's only part of #1256?

yes, we need to take this data, and parse it in gateway api library which I plan on doing in a follow up PR

what about endpoint, I know it will EOL soon, but in real world people always running old version kubernetes.

currently we only support last 3 k8s versions https://gateway.envoyproxy.io/v0.4.0/intro/compatibility.html#compatibility-matrix by the time we GA, my guess is most users will be using k8s versions with endpointslice enabled

I don't think that's the real world.

@arkodg
Copy link
Contributor Author

arkodg commented Jun 3, 2023

this's only part of #1256?

yes, we need to take this data, and parse it in gateway api library which I plan on doing in a follow up PR

what about endpoint, I know it will EOL soon, but in real world people always running old version kubernetes.

currently we only support last 3 k8s versions https://gateway.envoyproxy.io/v0.4.0/intro/compatibility.html#compatibility-matrix by the time we GA, my guess is most users will be using k8s versions with endpointslice enabled

I don't think that's the real world.

users can always revert to the ClusterIP LB policy #1477

@zirain zirain merged commit d01263a into envoyproxy:main Jun 5, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants