feat: support timeout and failOpen/failClose knobs for Global RateLimiting #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Codecov Report
@@ Coverage Diff @@
## main #1704 +/- ##
==========================================
- Coverage 64.90% 64.85% -0.05%
==========================================
Files 84 84
Lines 12014 12023 +9
==========================================
Hits 7798 7798
- Misses 3727 3734 +7
- Partials 489 491 +2
|
tmsnan
force-pushed
the
dev-extend-global-ratelimit
branch
from
4e46cb2
to
4185459
Compare
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
arkodg
reviewed
Jul 25, 2023
arkodg
reviewed
Jul 25, 2023
|
some comments in API naming and types, but looks good overall, thanks ! |
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
|
/retest |
|
/retest |
arkodg
requested review from
a team,
kflynn,
zhaohuabing and
chauhanshubham
and removed request for
a team
Xunzhuo
changed the title
|
cc @arkodg, should this landing in v0.5? |
|
@zirain since this is an feature/API change, and rc has been released for v0.5, this cannot make it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support timeout and failOpen/failClose knobs for Global RateLimiting
releated #1655