Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cherry-pick GHA for v0.5 #1714

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jul 26, 2023

Signed-off-by: Arko Dasgupta arko@tetrate.io

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner July 26, 2023 21:47
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1714 (db4b009) into main (89d16a6) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
- Coverage   64.90%   64.79%   -0.12%     
==========================================
  Files          83       83              
  Lines       11912    11912              
==========================================
- Hits         7732     7718      -14     
- Misses       3701     3711      +10     
- Partials      479      483       +4     

see 2 files with indirect coverage changes

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, we can not cp commits into v0.4 and cherrypick/release-v0.4 won`t work anymore ?

Thoughts on adding instead of replacing ?

@zirain
Copy link
Contributor

zirain commented Jul 27, 2023

maybe we change upstream tool, make it more generic?

@zirain zirain merged commit b37e2e9 into envoyproxy:main Jul 27, 2023
18 checks passed
@arkodg
Copy link
Contributor Author

arkodg commented Jul 27, 2023

@Xunzhuo, in the future once we support patch versions we will need to keep steps for each minor release, right now we are only supporting v0.x.0 releases, I think it's safe to replace

@arkodg arkodg deleted the update-cherrypick-v0.5 branch July 27, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants