feat(proxy): introduce Concurrency under EnvoyProxy resource #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @zirain |
Codecov Report
@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
+ Coverage 64.77% 64.94% +0.16%
==========================================
Files 83 83
Lines 11925 11930 +5
==========================================
+ Hits 7725 7748 +23
+ Misses 3715 3702 -13
+ Partials 485 480 -5
|
ardikabs
force-pushed
the
feat-proxy-config
branch
from
d8cacd1
to
14cf30b
Compare
arkodg
reviewed
Jul 28, 2023
Signed-off-by: Ardika Bagus <me@ardikabs.com>
ardikabs
force-pushed
the
feat-proxy-config
branch
from
14cf30b
to
f79db5c
Compare
ardikabs
changed the title
arkodg
reviewed
Jul 31, 2023
arkodg
reviewed
Jul 31, 2023
arkodg
reviewed
Jul 31, 2023
ardikabs
force-pushed
the
feat-proxy-config
branch
from
f529612
to
f009c23
Compare
|
@ardikabs looks like you also need to run |
Signed-off-by: Ardika Bagus <me@ardikabs.com>
ardikabs
force-pushed
the
feat-proxy-config
branch
from
f009c23
to
647fda3
Compare
|
@arkodg yes, i missed the |
arkodg
approved these changes
Jul 31, 2023
arkodg
requested review from
a team,
kflynn,
LanceEa and
Xunzhuo
and removed request for
a team
zirain
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Introduce an additional field under
EnvoyProxyfor additional proxy-level configuration options. The idea should be similar to Istio's ProxyConfig.What this PR does / why we need it: Our use case demands configuring the non-default concurrency for the Envoy proxy which currently is not supported by Envoy Gateway.
Which issue(s) this PR fixes: #1718
Fixes #