Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update extending-envoy-gateway.md to match the API Reference #1725

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

rinswind
Copy link
Contributor

Fixes #1724

@rinswind rinswind requested a review from a team as a code owner July 28, 2023 16:32
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1725 (3d4bc22) into main (9ba9103) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
+ Coverage   64.86%   64.88%   +0.01%     
==========================================
  Files          83       83              
  Lines       11924    11924              
==========================================
+ Hits         7735     7737       +2     
+ Misses       3707     3705       -2     
  Partials      482      482              

see 1 file with indirect coverage changes

Fixes envoyproxy#1724

Signed-off-by: Todor Boev <rinsvind@gmail.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested a review from AliceProxy July 28, 2023 18:21
@arkodg arkodg added this to the 0.5.0 milestone Jul 28, 2023
@zirain zirain merged commit a7354c9 into envoyproxy:main Jul 31, 2023
18 checks passed
@rinswind rinswind deleted the patch-1 branch July 31, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design document for Gateway Extension shows incorrect configuration
4 participants