Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add setvalue unit tests coverage #1735

Merged
merged 2 commits into from Aug 1, 2023
Merged

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Aug 1, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from a team as a code owner August 1, 2023 06:35
@Xunzhuo Xunzhuo changed the title test: add uts test: add setvalue unit tests coverage Aug 1, 2023
Signed-off-by: bitliu <bitliu@tencent.com>
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1735 (df84669) into main (ea18f8f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
- Coverage   64.77%   64.77%   -0.01%     
==========================================
  Files          83       84       +1     
  Lines       11925    11986      +61     
==========================================
+ Hits         7725     7764      +39     
- Misses       3715     3730      +15     
- Partials      485      492       +7     
Files Changed Coverage Δ
internal/utils/field/field.go 54.09% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg added this to the 0.6.0-rc1 milestone Aug 1, 2023
@arkodg arkodg merged commit 30dd8c6 into envoyproxy:main Aug 1, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants