Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm deprecated SourceIP field #1757

Merged
merged 4 commits into from Aug 3, 2023
Merged

rm deprecated SourceIP field #1757

merged 4 commits into from Aug 3, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Aug 3, 2023

Relates to #1308

@arkodg
rm deprecated SourceIP field
a596ceb 
Relates to envoyproxy#1308

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner August 3, 2023 00:03
@arkodg arkodg added the release-note Indicates a required release note label Aug 3, 2023
@arkodg
fix tests
a9f4070 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited

Codecov Report

Merging #1757 (8007d26) into main (72bfe9b) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1757      +/-   ##
==========================================
- Coverage   64.90%   64.85%   -0.06%     
==========================================
  Files          84       84              
  Lines       12014    12018       +4     
==========================================
- Hits         7798     7794       -4     
- Misses       3727     3733       +6     
- Partials      489      491       +2
Files Changed Coverage Δ
internal/gatewayapi/filters.go 80.06% <100.00%> (+0.60%) ⬆️

... and 4 files with indirect coverage changes

@arkodg
lint
8007d26 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zirain
zirain approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should do this before v1.0

@Xunzhuo Xunzhuo merged commit c96aa6a into envoyproxy:main Aug 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

Assignees
No one assigned
Labels
release-note Indicates a required release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arkodg @zirain @Xunzhuo